Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Arc features in datasource extensions for eager startup and active/inactive #41929

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Commits on Oct 1, 2024

  1. Configuration menu
    Copy the full SHA
    f3f541d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4bcd1c6 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Fail on startup when inactive datasources are injected into user beans

    By reimplementing Datasource inactive/active handling and eager startup
    through Arc's native features, which is better integrated and gives us
    this behavior.
    yrodiere committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    1822410 View commit details
    Browse the repository at this point in the history
  2. Always trim datasource URLs

    So that we correctly detect empty URLs.
    yrodiere committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    9844f87 View commit details
    Browse the repository at this point in the history
  3. Remove NoConfigTest for datasources

    Because it duplicates:
    
    * ConfigUrlMissingDefaultDatasourceStaticInjectionTest
    * ConfigUrlMissingDefaultDatasourceDynamicInjectionTest
    * ConfigUrlMissingNamedDatasourceStaticInjectionTest
    * ConfigUrlMissingNamedDatasourceDynamicInjectionTest
    yrodiere committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6622485 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bd1d176 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d233c73 View commit details
    Browse the repository at this point in the history
  6. Deactivate datasources when their URL is unset at runtime

    Consequently:
    
    * Skip the health check for datasources without a URL
    * Fail on startup if datasources without URL are (statically)
      injected into user bean
    * Fail on first access if datasources without URL are retrieved
      dynamically through CDI
    yrodiere committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d90eb86 View commit details
    Browse the repository at this point in the history
  7. Fail on startup when Flyway/Liquibase for inactive datasources are in…

    …jected into user beans
    
    By reimplementing Flyway's/Liquibase's inactive/active handling and eager
    startup through Arc's native features, which is better integrated and gives
    us this behavior.
    yrodiere committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    36b7922 View commit details
    Browse the repository at this point in the history
  8. Update Hibernate ORM's "active" documentation

    For consistency with datasource documentation.
    yrodiere committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    9e62f0f View commit details
    Browse the repository at this point in the history