Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpoint configuration #18

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Breakpoint configuration #18

merged 2 commits into from
Apr 3, 2024

Conversation

davidhoelzel
Copy link
Member

No description provided.

@davidhoelzel davidhoelzel merged commit 7c8dff7 into main Apr 3, 2024
2 checks passed
@davidhoelzel davidhoelzel deleted the breakpoint-configuration branch April 4, 2024 07:01
davidhoelzel added a commit that referenced this pull request Apr 4, 2024
* add breakpoint config
bschultz added a commit that referenced this pull request Apr 4, 2024
* #11 use nelmio/alice for data-faking

* #11 cs-fixer

* #11 implemented generators for providing template data

* Update docs/ComponentConfiguration.md

Co-authored-by: Benjamin Schultz <[email protected]>

* Update tests/Unit/Component/ComponentItemFactoryTest.php

Co-authored-by: Benjamin Schultz <[email protected]>

* Breakpoint configuration (#18)

* add breakpoint config

* add disclaimer

- added forgotten documentation for breakpoints

* Fix typo

* Optimize function calls

[EA] '$item->$method()' would make more sense here (it's also faster).

* Fix route prefix

Regarding best practices, the bundle routes must be prefixed with the bundle alias.

* Cleanup and optimize code

Add strict types and return types where it was missing.

* merge update

* add class usages

* #11 code review changes

- added cs-fixer rule for strict types

* #11 code review changes

---------

Co-authored-by: Benjamin Schultz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant