#27 fix NULL generator implementation

- returns NULL when context is NULL or ''
qossmic · Apr 23, 2024 · be31c1e · be31c1e
1 parent d6e9fdf
commit be31c1e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/Component/Data/Faker.php b/src/Component/Data/Faker.php
@@ -46,7 +46,7 @@ private function createFakeData(array $params, mixed $variation): array
 
             if (!\array_key_exists($name, $result)) {
                 // set from variation
-                $result[$name] = $variation;
+                $result[$name] = $variation[$name] ?? $variation;
             }
         }
 

diff --git a/src/Component/Data/Generator/NullGenerator.php b/src/Component/Data/Generator/NullGenerator.php
@@ -10,7 +10,7 @@ class NullGenerator implements GeneratorInterface
 {
     public function supports(string $type, mixed $context = null): bool
     {
-        return empty($context);
+        return null === $context || '' === $context;
     }
 
     public function generate(string $type, mixed $context = null): null

diff --git a/tests/Functional/Service/ComponentItemFactoryTest.php b/tests/Functional/Service/ComponentItemFactoryTest.php
@@ -261,6 +261,7 @@ public function testCreateForArrayParameter(): void
                 'variation1' => [
                     'arrayParam' => [
                         'param1' => 'Some cool hipster text',
+                        'param2' => false,
                     ],
                 ],
             ],
@@ -275,7 +276,7 @@ public function testCreateForArrayParameter(): void
         self::assertIsArray($variations);
         self::assertArrayHasKey('variation1', $variations);
         self::assertEquals('Some cool hipster text', $variations['variation1']['arrayParam']['param1']);
-        self::assertIsBool($variations['variation1']['arrayParam']['param2']);
+        self::assertFalse($variations['variation1']['arrayParam']['param2']);
     }
 
     public static function getInvalidComponentConfigurationTestCases(): iterable