#23 create fake variation value when not given

qossmic · Apr 19, 2024 · 320fe21 · 320fe21
1 parent 2488b65
commit 320fe21
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/src/Component/ComponentItemFactory.php b/src/Component/ComponentItemFactory.php
@@ -129,7 +129,7 @@ private function createVariationParameters(array $parameters, array $variation):
             if (\is_array($type)) {
                 $paramValue = $this->createVariationParameters($type, $variation[$name] ?? []);
             } else {
-                $paramValue = $this->faker->getFakeData([$name => $type], $variation[$name]);
+                $paramValue = $this->faker->getFakeData([$name => $type], $variation[$name] ?? []);
             }
             $params += $paramValue;
         }

diff --git a/tests/Functional/Service/ComponentItemFactoryTest.php b/tests/Functional/Service/ComponentItemFactoryTest.php
@@ -207,6 +207,38 @@ public function testCreateForObjectParameter(): void
         static::assertEquals('Mitsubishi', $car->getManufacturer()->getName());
     }
 
+    public function testCreateForParamWithOptionalVariationValue()
+    {
+        $data = [
+            'name' => 'component',
+            'title' => 'title',
+            'description' => 'description',
+            'category' => 'MainCategory',
+            'path' => 'path',
+            'renderPath' => 'renderPath',
+            'parameters' => [
+                'stringParam' => 'String',
+                'secondParam' => 'String',
+            ],
+            'variations' => [
+                'variation1' => [
+                    'stringParam' => 'Some cool hipster text',
+                ],
+            ],
+        ];
+
+        /** @var ComponentItemFactory $factory */
+        $factory = self::getContainer()->get('twig_doc.service.component_factory');
+
+        $item = $factory->create($data);
+        $variations = $item->getVariations();
+
+        self::assertIsArray($variations);
+        self::assertArrayHasKey('variation1', $variations);
+        self::assertArrayHasKey('secondParam', $variations['variation1']);
+        self::assertIsString($variations['variation1']['secondParam']);
+    }
+
     public static function getInvalidComponentConfigurationTestCases(): iterable
     {
         yield [