Test dependencies from method signatures

This adds a test case that checks for dependencies derived from method signatures.
qossmic · Dec 22, 2023 · 1fb31c7 · 1fb31c7
1 parent 4bb7ddc
commit 1fb31c7
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 0 deletions.
diff --git a/tests/Core/Ast/AstMapGeneratorTest.php b/tests/Core/Ast/AstMapGeneratorTest.php
@@ -22,6 +22,8 @@
 use Symfony\Component\EventDispatcher\EventDispatcher;
 use Tests\Qossmic\Deptrac\Core\Ast\Fixtures\BasicDependency\BasicDependencyClassB;
 use Tests\Qossmic\Deptrac\Core\Ast\Fixtures\BasicDependency\BasicDependencyClassC;
+use Tests\Qossmic\Deptrac\Core\Ast\Fixtures\BasicDependency\BasicDependencyMethodSignatureB;
+use Tests\Qossmic\Deptrac\Core\Ast\Fixtures\BasicDependency\BasicDependencyMethodSignatureC;
 use Tests\Qossmic\Deptrac\Core\Ast\Fixtures\BasicDependency\BasicDependencyTraitA;
 use Tests\Qossmic\Deptrac\Core\Ast\Fixtures\BasicDependency\BasicDependencyTraitB;
 use Tests\Qossmic\Deptrac\Core\Ast\Fixtures\BasicDependency\BasicDependencyTraitC;
@@ -126,6 +128,26 @@ static function (DependencyToken $dependency) {
         );
     }
 
+    public function testBasicDependencyMethodSignature(): void
+    {
+        $astMap = $this->getAstMap(__DIR__.'/Fixtures/BasicDependency/BasicDependencyMethodSignature.php');
+
+        self::assertArrayValuesEquals(
+            [
+                'Tests\Qossmic\Deptrac\Core\Ast\Fixtures\BasicDependency\BasicDependencyMethodSignatureA::12 (Returns)',
+            ],
+            $this->getInheritsAsString($astMap->getClassReferenceForToken(ClassLikeToken::fromFQCN(BasicDependencyMethodSignatureB::class)))
+        );
+
+        self::assertArrayValuesEquals(
+            [
+                'Tests\Qossmic\Deptrac\Core\Ast\Fixtures\BasicDependency\BasicDependencyMethodSignatureB::20 (Parameter)',
+                'Tests\Qossmic\Deptrac\Core\Ast\Fixtures\BasicDependency\BasicDependencyMethodSignatureA::22 (Variable)',
+            ],
+            $this->getInheritsAsString($astMap->getClassReferenceForToken(ClassLikeToken::fromFQCN(BasicDependencyMethodSignatureC::class)))
+        );
+    }
+
     /**
      * @return string[]
      */

diff --git a/tests/Core/Ast/Fixtures/BasicDependency/BasicDependencyMethodSignature.php b/tests/Core/Ast/Fixtures/BasicDependency/BasicDependencyMethodSignature.php
@@ -0,0 +1,28 @@
+<?php
+
+namespace Tests\Qossmic\Deptrac\Core\Ast\Fixtures\BasicDependency;
+
+class BasicDependencyMethodSignatureA
+{
+    public function foo() {}
+}
+
+class BasicDependencyMethodSignatureB
+{
+    public function getA(): ?BasicDependencyMethodSignatureA
+    {
+        // no-op
+        return null;
+    }
+}
+
+class BasicDependencyMethodSignatureC
+{
+    public function test( BasicDependencyMethodSignatureB $b )
+    {
+        $a = $b->getA();
+        $a->foo();
+    }
+
+}
+