Check warning msg in second captured warning. #8069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pytorch will run this in CI and in PR pytorch/pytorch#125888.
We are try to design some new APIs and this ut will trigger a warning since we are using old APIs here.
I do not have an xla at hand and I cannot reproduce it with my cpu device. From my understanding, the warning msg to be checked here should be able to be checked not only on the first warning.
I wander shall we check it at the second warning msg. And no matter whether pytorch/pytorch#125888 is merged, this change does not impact the functionality of this UT?