Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix export tutorial #3130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix export tutorial #3130

wants to merge 1 commit into from

Conversation

angelayi
Copy link
Contributor

Fixing issues from @lucylq (thanks!)

Description

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3130

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c371b99 with merge base e05e623 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@angelayi angelayi force-pushed the angelayi/export_fix branch from 3463b49 to 74715d4 Compare October 30, 2024 18:23
@svekars
Copy link
Contributor

svekars commented Oct 30, 2024

I believe we need to enable here: https://github.com/pytorch/tutorials/blob/main/.jenkins/validate_tutorials_built.py#L52

@angelayi angelayi force-pushed the angelayi/export_fix branch from 74715d4 to c371b99 Compare October 30, 2024 23:20
@angelayi angelayi requested a review from svekars October 31, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucylq lucylq lucylq approved these changes

@svekars svekars Awaiting requested review from svekars

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@angelayi @svekars @lucylq @facebook-github-bot