-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logging issue for unsupported torch.compile devices #3077
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3077
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @rghosh08! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Small suggestion - Link the PR to the issue. Currently the issue has no linked PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why everything is being deleted here.
@rghosh08 I don't think this PR makes sense, as logging is explicitly meant for INFO:__main__:CUDA Device Capability: (8, 0)
INFO:__main__:Device supports torch.compile.
INFO:__main__:Running the function without compilation...
===================Dynamo Tracing=========================
===================Traced Graph=========================
===================Fusion Decisions=========================
===================Output Code=========================
============================================ I also don't understand why so much of the tutorial aspect of the script is getting removed. Can you explain further? |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Fixes #137285
Description
This PR addresses the issue of insufficient logging when
torch.compile
is not supported on devices with CUDA capability below 7.0. Instead of exiting the program with a simple message, the code now logs detailed information about the device capabilities and reasons for the lack of support fortorch.compile
. It also ensures that the program continues to execute, showcasing theTORCH_LOGS
logging system even when the function is not compiled.Changes made:
torch.compile
is not supported on devices with lower CUDA capabilities.TORCH_LOGS
regardless of device capabilities.Checklist