Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial inductor on Windows CPU #3062

Merged
merged 18 commits into from
Sep 30, 2024
Merged

Add tutorial inductor on Windows CPU #3062

merged 18 commits into from
Sep 30, 2024

Conversation

ZhaoqiongZ
Copy link
Contributor

@ZhaoqiongZ ZhaoqiongZ commented Sep 26, 2024

Add tutorial inductor on Windows CPU

CC: @jgong5

Copy link

pytorch-bot bot commented Sep 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3062

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 319c395 with merge base 01d2270 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
@svekars svekars added the 2.5 PR related to version 2.5 label Sep 26, 2024
@svekars
Copy link
Contributor

svekars commented Sep 26, 2024

Can you please add to the https://github.com/pytorch/tutorials/blob/main/prototype_source/prototype_index.rst so it's included in the toctree.

prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
@ZhaoqiongZ
Copy link
Contributor Author

Can you please add to the https://github.com/pytorch/tutorials/blob/main/prototype_source/prototype_index.rst so it's included in the toctree.

have done so

@ZhaoqiongZ
Copy link
Contributor Author

Hi @svekars , I have add a new section to complete the tutorial and also add the tutorial to prototype_index.rst

@ZhaoqiongZ ZhaoqiongZ changed the title [draft] Add tutorial inductor on Windows CPU Add tutorial inductor on Windows CPU Sep 27, 2024
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
prototype_source/inductor_windows_cpu.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please file an issue and follow-up with an update once you have the intel compiler blog link

@svekars svekars merged commit 8d959ca into pytorch:main Sep 30, 2024
19 checks passed
.. code-block:: sh

"C:/ProgramData/miniforge3/Scripts/activate.bat"
#. Create and activate a customer conda environment:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "custom" conda environment, shouldn't it?

opt_foo1 = torch.compile(foo)
print(opt_foo1(torch.randn(10, 10), torch.randn(10, 10)))

The code above returns the following output:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would not, would it? As inputs are random

Comment on lines +75 to +77
def foo(x, y):
a = torch.sin(x)
b = torch.cos(x)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If function takes two arguments, should 2nd one be used somewhere? (i.e. y argument is currently unused in the codebase, is it?)

@xuhancn
Copy link

xuhancn commented Oct 3, 2024

@ZhaoqiongZ let's create another PR to fix @malfet 's comments, after national holiday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.5 PR related to version 2.5 cla signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants