Moved logits .float() to loss and compiled it if compiling
#551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Aug 21, 2024
ghstack-source-id: 6a83cae2c00f1384c02925fe686e3b222664b8de Pull Request resolved: #551
facebook-github-bot
added
the
CLA Signed
yifuwang
approved these changes
Aug 21, 2024
|
@yifuwang I need to fix PP before this is landable 😢 |
[ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Aug 23, 2024
ghstack-source-id: 99a696d59af53f173d0af0b5c589056b4d76c7de Pull Request resolved: #551
awgu
commented
Aug 23, 2024
| @@ -137,7 +137,7 @@ def main(job_config: JobConfig): | |||
| # loss function to be shared by Pipeline Parallel and SPMD training | |||
| def loss_fn(pred, labels): | |||
| return torch.nn.functional.cross_entropy( | |||
| pred.flatten(0, 1), labels.flatten(0, 1) | |||
| pred.flatten(0, 1).float(), labels.flatten(0, 1) | |||
There was a problem hiding this comment.
cc: @Chillee torch.compile should respect this upcast numerically?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
.float()to loss and compiled it if compiling #551Compiling the loss improves performance. Moving the
.float()upcast to inside this compiled loss further improves performance.