add unit test for compiled_rmsnorm #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
tianyu-l
added a commit
that referenced
this pull request
Aug 6, 2024
ghstack-source-id: d3e5dbd16316c6c5ebc342273da717ddec73b92b Pull Request resolved: #506
facebook-github-bot
added
the
CLA Signed
This was referenced Aug 6, 2024
tianyu-l
force-pushed
the
gh/tianyu-l/19/head
branch
from
6eb2a27
to
be7cee8
Compare
tianyu-l
added a commit
that referenced
this pull request
Aug 16, 2024
ghstack-source-id: d3e5dbd16316c6c5ebc342273da717ddec73b92b Pull Request resolved: #506
|
see updates in #535 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
TODO: actually the rms test file is not tested in CI -- it was put only in CPU unit test (not GPU integration tests), but decorated with
skip_if_lt_x_gpu. We probably should add another GPU unit test CI file.