Fix parsing of pp split points from toml file #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wconstab
added a commit
that referenced
this pull request
Jul 10, 2024
Previously, string_list formatting was only applied to pp split points arg when it came from the cmd line. The string_list formatting needs to be applied when loading via toml too. ghstack-source-id: fb41e66314e7fd79c02509ba68e3dc590d5f6976 Pull Request resolved: #450
facebook-github-bot
added
the
CLA Signed
tianyu-l
force-pushed
the
gh/wconstab/38/head
branch
from
a379120
to
f5d7255
Compare
tianyu-l
pushed a commit
that referenced
this pull request
Aug 16, 2024
Previously, string_list formatting was only applied to pp split points arg when it came from the cmd line. The string_list formatting needs to be applied when loading via toml too. ghstack-source-id: fb41e66314e7fd79c02509ba68e3dc590d5f6976 Pull Request resolved: #450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Previously, string_list formatting was only applied to pp split points
arg when it came from the cmd line. The string_list formatting needs to
be applied when loading via toml too.