Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing tb logs #389

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix missing tb logs #389

merged 1 commit into from
Jun 10, 2024

Conversation

tianyu-l
Copy link
Contributor

@tianyu-l tianyu-l commented Jun 10, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@tianyu-l
fix missing tb logs
6f24426 
[ghstack-poisoned]
tianyu-l added a commit that referenced this pull request Jun 10, 2024
@tianyu-l
fix missing tb logs
79b3d4c 
ghstack-source-id: ac3501485faa093c8b9daacca9917805e2a987b7
Pull Request resolved: #389
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 10, 2024
lessw2020
lessw2020 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@lessw2020 lessw2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast fix!

@tianyu-l tianyu-l merged commit 6f24426 into gh/tianyu-l/12/base Jun 10, 2024
5 checks passed
tianyu-l added a commit that referenced this pull request Jun 10, 2024
@tianyu-l
fix missing tb logs
9700e0f 
ghstack-source-id: ac3501485faa093c8b9daacca9917805e2a987b7
Pull Request resolved: #389
@tianyu-l tianyu-l deleted the gh/tianyu-l/12/head branch June 10, 2024 20:51
tianyu-l added a commit to tianyu-l/torchtitan_intern24 that referenced this pull request Aug 16, 2024
@tianyu-l
fix missing tb logs
32a9cef 
ghstack-source-id: ac3501485faa093c8b9daacca9917805e2a987b7
Pull Request resolved: pytorch#389
philippguevorguian pushed a commit to YerevaNN/YNNtitan that referenced this pull request Aug 17, 2024
@tianyu-l
fix missing tb logs
3e5c0aa 
ghstack-source-id: ac3501485faa093c8b9daacca9917805e2a987b7
Pull Request resolved: pytorch#389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lessw2020 lessw2020 lessw2020 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tianyu-l @lessw2020 @facebook-github-bot