-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow tests for benchmarks #362
Draft
scotts
wants to merge
17
commits into
pytorch:main
Choose a base branch
from
scotts:benchmark_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+109
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
Nov 12, 2024
scotts
force-pushed
the
benchmark_test
branch
7 times, most recently
from
November 12, 2024 14:50
98f39c4
to
df8ee9b
Compare
scotts
force-pushed
the
benchmark_test
branch
from
November 12, 2024 14:56
df8ee9b
to
960b620
Compare
scotts
force-pushed
the
benchmark_test
branch
from
November 13, 2024 02:55
1c7ad5f
to
9e59bab
Compare
scotts
commented
Nov 13, 2024
@@ -13,7 +13,7 @@ | |||
|
|||
from benchmark_decoders_library import ( | |||
AbstractDecoder, | |||
BatchParameters, | |||
# BatchParameters, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore changes in this file; once we fix these failures on trunk, I'll pull those changes. These changes just let this run without error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not currently testing our benchmarks. This is a problem, because we tend to only run the benchmarks in phases when we're digging into performance. This means it's easy for our benchmarks to be silently broken when we make code changes. This PR adds a benchmark testing workflow, and makes
generate_readme_data.py
easy to run in a test mode.We'll want to expand this workflow to test all benchmarks we care about. This means we'll probably need to move it to GPU instances, but we can iterate on that.
PR Status
The benchmark test passes, but what I needed to do to get it to pass has surprised me:
video_reader
backend is not available. Installing from source following the official instructions causes a segfault in the benchmark. I admit I did not investigate that much, and eventually tried using conda instead of pip because that's how I happened to have set up my own dev environment, and I don't believe I installed TorchVision from source.ffmpeg=4
in order for TorchAudio to be able to find the ffmpeg libraries at runtime.I suspect, but have not yet confirmed, that part of the problem is caused by Decord bundling the FFmpeg binaries in their library. I will test this by running the benchmark without Decord next.