Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create distributed.md #1438

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Create distributed.md #1438

wants to merge 13 commits into from

Conversation

mikekgfb
Copy link
Contributor

@mikekgfb mikekgfb commented Dec 22, 2024

Initial documentation for use of distributed inference w/ torchchat. @mreso @lessw2020 @kwen2501 please review and update as appropriate.

Initial documentation for use of distributed inference w/ torchchat.
@mreso please review and update as appropriate.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 22, 2024
Copy link

pytorch-bot bot commented Dec 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1438

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Add support for extracting distributed inference tests in run-docs
@Jack-Khuu Jack-Khuu added the Distributed Issues related to all things distributed label Dec 23, 2024
Copy link
Contributor

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much for writing it up!

Copy link
Contributor

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikekgfb looks good, the response of the server is a bit different but thats true for the non distributed case too.

docs/distributed.md Outdated Show resolved Hide resolved
Comment on lines 29 to 31
<!--
[skip default]: begin
## Generate output (requires testing and review by mreso)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!--
[skip default]: begin
## Generate output (requires testing and review by mreso)
<!--
[skip default]: begin
## Generate output

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that works

docs/distributed.md Outdated Show resolved Hide resolved
mikekgfb and others added 6 commits December 24, 2024 03:06
Co-authored-by: Matthias Reso <[email protected]>
Co-authored-by: Matthias Reso <[email protected]>
Uncommenting  section about generate subcommand w/ distributed inference after review by @mreso
Also, Added HF login to make this fully self-contained
Wording and formatting
@mikekgfb
Copy link
Contributor Author

mikekgfb commented Dec 24, 2024

@mreso @kwen2501 @lessw2020 do you have a perspective what list of models will run with distributed? I know we had a separate model dictionary at some point?

Or should we just sweep all the models from README.md and see which work? With this integration this will be pretty easy and cool to do. (yay!) Is there a minimum size for models to run distributed? I know below a certain size it doesn't make sense to run distributed inference, but just for kicks (or a test that's quick to download?)... can it run stories 15M on distributed?

Any attempts at 405B? Wer should def add some of the super large models to the models.Json so they're accessible for distributed inference?

Also, should we create a spare table here, or we could put a second column in the main readme for "distributed inference"? Next to "mobile" column?

Since I'm on a roll asking questions, I'll assume it works only on GPUs (only on CUDA?!), not CPU? Should we add that somewhere? Wanna suggest wording to this effect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. Distributed Issues related to all things distributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants