Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evaluation, multimodal, native tests to run-readme-pr-mps.yml #1410

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mikekgfb
Copy link
Contributor

Add evaluation, multimodal, native tests to run-readme-pr-mps.yml

Add evaluation, multimodal, native tests to run-readme-pr-mps.yml
Copy link

pytorch-bot bot commented Dec 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1410

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 0de9067 with merge base 68b8087 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 10, 2024
@Jack-Khuu
Copy link
Contributor

Just realized that none of the test in this file are being ran:

Invalid workflow file: .github/workflows/run-readme-pr-mps.yml#L13
The workflow is not valid. .github/workflows/run-readme-pr-mps.yml (Line: 13, Col: 24): Invalid input, timeout-minutes is not defined in the referenced workflow.

@mikekgfb
Copy link
Contributor Author

Just realized that none of the test in this file are being ran:

Invalid workflow file: .github/workflows/run-readme-pr-mps.yml#L13
The workflow is not valid. .github/workflows/run-readme-pr-mps.yml (Line: 13, Col: 24): Invalid input, timeout-minutes is not defined in the referenced workflow.

Should be fixed now. Please rerun tests?

Extend timeout for test-readme-mps to avoid test failing from timeout.
@mikekgfb
Copy link
Contributor Author

Just realized that none of the test in this file are being ran:

Invalid workflow file: .github/workflows/run-readme-pr-mps.yml#L13
The workflow is not valid. .github/workflows/run-readme-pr-mps.yml (Line: 13, Col: 24): Invalid input, timeout-minutes is not defined in the referenced workflow.

Should be fixed now. Please rerun tests?

Still timed out @ 50 minutes, increased timeout further.

Beyond the "let's extend timeout" bandaid, I'm wondering whether this may be due to us trying to update llvm+openmp with the command conda create -y -n test-readme-mps-macos python=3.10.11 llvm-openmp which may be adding significant runtime to the test? This might benefit from somebody looking at it who is familiar with pytorch ci/cd setup on github? (i.e., the pt releng team.

Also, MPS is the only set of doc tests using conda, which on the one hand is good because we're testing setup with conda as well, but otoh makes MPS the odd man platform out at the moment.

@@ -90,7 +90,7 @@ jobs:
test-advanced-mps-macos:
uses: pytorch/test-infra/.github/workflows/macos_job.yml@main
with:
runner: macos-m1-14 # neeps MPS, was macos-m1-stable
runner: macos-m1-14 # needs MPS, was macos-m1-stable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice typo fix, should we land it as separate PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants