subclass PredictUnit in AutoUnit #545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D49441091 |
JKSenthil
added a commit
to JKSenthil/tnt
that referenced
this pull request
Sep 20, 2023
Summary: # Context Currently if users want to train, eval, and predict all in one script, they must transfer their modules from AutoUnit to AutoPredictUnit, which is unintuitive and can be error prone # This diff We subclass in PredictUnit in AutoUnit, which allows users to use the existing predict_step, or override it, when calling `predict` Differential Revision: D49441091
JKSenthil
force-pushed
the
export-D49441091
branch
from
2d903dc
to
d419f04
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49441091 |
JKSenthil
added a commit
to JKSenthil/tnt
that referenced
this pull request
Sep 20, 2023
Summary: # Context Currently if users want to train, eval, and predict all in one script, they must transfer their modules from AutoUnit to AutoPredictUnit, which is unintuitive and can be error prone # This diff We subclass in PredictUnit in AutoUnit, which allows users to use the existing predict_step, or override it, when calling `predict` Differential Revision: D49441091
JKSenthil
force-pushed
the
export-D49441091
branch
from
d419f04
to
f77d11b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49441091 |
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
==========================================
+ Coverage 86.84% 86.86% +0.01%
==========================================
Files 62 62
Lines 3931 3943 +12
==========================================
+ Hits 3414 3425 +11
- Misses 517 518 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Summary: # Context Currently if users want to train, eval, and predict all in one script, they must transfer their modules from AutoUnit to AutoPredictUnit, which is unintuitive and can be error prone # This diff We subclass in PredictUnit in AutoUnit, which allows users to use the existing predict_step, or override it, when calling `predict` Differential Revision: D49441091
JKSenthil
force-pushed
the
export-D49441091
branch
from
f77d11b
to
f9b963b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49441091 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Currently if users want to train, eval, and predict all in one script, they must transfer their modules from AutoUnit to AutoPredictUnit, which is unintuitive and can be error prone
This diff
We subclass in PredictUnit in AutoUnit, which allows users to use the existing predict_step, or override it, when calling
predictDifferential Revision: D49441091