fix pyre targets #508
Closed
fix pyre targets #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D48478829 |
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
=======================================
Coverage 86.95% 86.95%
=======================================
Files 106 106
Lines 8407 8407
=======================================
Hits 7310 7310
Misses 1097 1097
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request was exported from Phabricator. Differential Revision: D48478829 |
galrotem
added a commit
to galrotem/tnt
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: pytorch#508 # Context `pyre` is not configured properly for `torchtnt`. The config is in `torchtnt/.pyre_configuration.local` and the coverage is very partial # This diff 1. Fix `torchtnt/.pyre_configuration.local` 2. Codemod and add `pyre-fixme` to any pyre errors as a result `pyre --output=json check | pyre-upgrade fixme` 3. Fix any `lints` as a result 4. Fix the `pyre` issues that `lint` resurfaced Reviewed By: ananthsub Differential Revision: D48478829 fbshipit-source-id: d5ec136b7a92c8fa5fb0a178b9a318b5295ed62e
galrotem
force-pushed
the
export-D48478829
branch
from
4e4ea76
to
032f6b4
Compare
Summary: Pull Request resolved: pytorch#508 # Context `pyre` is not configured properly for `torchtnt`. The config is in `torchtnt/.pyre_configuration.local` and the coverage is very partial # This diff 1. Fix `torchtnt/.pyre_configuration.local` 2. Codemod and add `pyre-fixme` to any pyre errors as a result `pyre --output=json check | pyre-upgrade fixme` 3. Fix any `lints` as a result 4. Fix the `pyre` issues that `lint` resurfaced Reviewed By: ananthsub Differential Revision: D48478829 fbshipit-source-id: fdcb7d5fa1898a07a68dd97a29242e3596bb2907
|
This pull request was exported from Phabricator. Differential Revision: D48478829 |
galrotem
force-pushed
the
export-D48478829
branch
from
032f6b4
to
398f1e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
pyreis not configured properly fortorchtnt. The config is intorchtnt/.pyre_configuration.localand the coverage is very partialThis diff
torchtnt/.pyre_configuration.localpyre-fixmeto any pyre errors as a resultpyre --output=json check | pyre-upgrade fixmelintsas a resultpyreissues thatlintresurfacedDifferential Revision: D48478829