Replace auto_timing arg with timer #466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `fit` can just call `_train_impl` and we can remove `_fit_impl`. Differential Revision: D47621579 fbshipit-source-id: 06cc0d79fda91a5fa01a4fb7eb91ccb365d9048b
Summary: We currently call `_set_module_training_mode`/`_reset_module_training_mode` in two places in train.py. We did this to support the `train_epoch` API but this was removed in (pytorch#421) Differential Revision: D47621624 fbshipit-source-id: 970619f3bae99960e797230866c9ac3112f3fc5f
Summary: Users are now expected to pass in a Timer themselves, and to time their own code using `state.timer.time()` or `get_timing_context`, which we expose as a public function in this diff. We time the code in the AutoUnit and the built-in callbacks for the user. Differential Revision: D47523530 fbshipit-source-id: 9ac77b93cd8a0990571a4cfb3a5158dff40b54e8
|
This pull request was exported from Phabricator. Differential Revision: D47523530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Users are now expected to pass in a Timer themselves, and to time their own code using
state.timer.time()orget_timing_context, which we expose as a public function in this diff.We time the code in the AutoUnit and the built-in callbacks for the user.
Differential Revision: D47523530