Move Validation Framework workflows to test-infra #6029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
test fix test test test path fix test test test fix validate_binary fix test fix fix actionlint fix test fix fix fix fix test test fix fix
atalman
force-pushed
the
move_validation_workflows
branch
from
927ad7d to
1e39f04
Compare
atalman
changed the title
atalman
commented
Dec 11, 2024
| @@ -41,8 +41,8 @@ on: | |||
| type: string | |||
| use-only-dl-pytorch-org: | |||
| description: "Use only download.pytorch.org when generating wheel install command?" | |||
| default: "false" | |||
| type: string | |||
| default: false | |||
There was a problem hiding this comment.
Corrected this in original worklfow
huydhn
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Stamped! If I get this correctly, we need to land this before we can try it out on https://github.com/pytorch/test-infra/actions
|
@huydhn its already running nightlies tests here: https://github.com/pytorch/test-infra/actions/runs/12285444475/job/34283477325?pr=6029 |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Dec 12, 2024
After PR: pytorch/test-infra#6029 use validate-docker-images.yml from test-infra. Related to: pytorch/builder#2054 Pull Request resolved: #143081 Approved by: https://github.com/huydhn
pytorchbot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Dec 12, 2024
After PR: pytorch/test-infra#6029 use validate-docker-images.yml from test-infra. Related to: pytorch/builder#2054 Pull Request resolved: #143081 Approved by: https://github.com/huydhn (cherry picked from commit bd7d81d)
kit1980
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Dec 12, 2024
Use validate-docker-images workflow from test-infra (#143081) After PR: pytorch/test-infra#6029 use validate-docker-images.yml from test-infra. Related to: pytorch/builder#2054 Pull Request resolved: #143081 Approved by: https://github.com/huydhn (cherry picked from commit bd7d81d) Co-authored-by: atalman <[email protected]>
bluenote10
pushed a commit
to bluenote10/pytorch
that referenced
this pull request
Dec 14, 2024
After PR: pytorch/test-infra#6029 use validate-docker-images.yml from test-infra. Related to: pytorch/builder#2054 Pull Request resolved: pytorch#143081 Approved by: https://github.com/huydhn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all the worklfows from builder Validation framework except:
https://github.com/pytorch/builder/blob/main/.github/workflows/validate-repackaged-binary-sizes.yml
Part of pytorch/builder#2054
It needs to be rewritten, followup PR required.