Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nvidia-driver to linux_job workflow #5435

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/actions/setup-linux/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@ name: Setup Linux

description: Set up Docker workspace on EC2

inputs:
nvidia-driver:
description: If set will install required nvidia driver
required: false
type: string
default: ''

runs:
using: composite
steps:
Expand Down Expand Up @@ -77,8 +84,14 @@ runs:
echo "does=${needs}" >> $GITHUB_OUTPUT

- name: Install nvidia driver, nvidia-docker runtime, set GPU_FLAG
if: ${{ steps.needs-nvidia-driver.outputs.does == 1 && inputs.nvidia-driver == ''}}
uses: pytorch/test-infra/.github/actions/setup-nvidia@main

- name: Install nvidia driver specific version, nvidia-docker runtime, set GPU_FLAG
if: ${{ inputs.nvidia-driver != '' }}
uses: pytorch/test-infra/.github/actions/setup-nvidia@main
if: ${{ steps.needs-nvidia-driver.outputs.does == 1 }}
with:
nvidia-driver: inputs.nvidia-driver

- name: Kill any existing containers, clean up images
shell: bash
Expand Down
5 changes: 5 additions & 0 deletions .github/actions/setup-nvidia/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ runs:
echo "Failed to get NVIDIA driver version ($INSTALLED_DRIVER_VERSION). Continuing"
elif [ "$INSTALLED_DRIVER_VERSION" != "$DRIVER_VERSION" ]; then
echo "NVIDIA driver ($INSTALLED_DRIVER_VERSION) has been installed, but we expect to have $DRIVER_VERSION instead. Continuing"
# First Uninstall old driver
sudo nvidia-uninstall -s
else
HAS_NVIDIA_DRIVER=1
echo "NVIDIA driver ($INSTALLED_DRIVER_VERSION) has already been installed. Skipping NVIDIA driver installation"
Expand All @@ -104,6 +106,9 @@ runs:
sudo curl -fsL -o /tmp/nvidia_driver "https://s3.amazonaws.com/ossci-linux/nvidia_driver/$DRIVER_FN"

set +e
# unload any possible nvidia processes
sudo kill 9 $(pgrep nvidia)
# install nvidia driver
sudo /bin/bash /tmp/nvidia_driver -s --no-drm
NVIDIA_INSTALLATION_STATUS=$?

Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/linux_job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ on:
required: false
default: false
type: boolean
nvidia-driver:
Dismissed Show dismissed Hide dismissed
description: If set will install required nvidia driver
required: false
type: string
default: ''
jobs:
job:
name: ${{ inputs.job-name }}
Expand Down Expand Up @@ -148,6 +153,8 @@ jobs:

- name: Setup Linux
uses: ./test-infra/.github/actions/setup-linux
with:
nvidia-driver: inputs.nvidia-driver

- name: Setup SSH
uses: ./test-infra/.github/actions/setup-ssh
Expand Down
19 changes: 19 additions & 0 deletions .github/workflows/test-setup-nvidia.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,22 @@ jobs:

- name: Test that setup-nvidia works
uses: ./.github/actions/setup-nvidia
test-minimal-version:
strategy:
fail-fast: false
matrix:
runner-type:
- linux.g5.4xlarge.nvidia.gpu
name: Install NVIDIA driver on ${{ matrix.runner-type }}
runs-on: ${{ matrix.runner-type }}
timeout-minutes: 15
steps:
- uses: actions/checkout@v3
- name: Setup SSH
uses: ./.github/actions/setup-ssh
with:
github-secret: ${{ github.token }}
- name: Test that setup-nvidia works
uses: ./.github/actions/setup-nvidia
with:
driver-version: "470.161.03"
Loading