Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] TensorDictBase.masked_select_ inplace #393

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Feature] TensorDictBase.masked_select_ inplace #393

wants to merge 8 commits into from

Conversation

xmaples
Copy link
Contributor

@xmaples xmaples commented May 22, 2023 •
edited
Loading

Description

See the feature request pytorch/rl#1178

Types of changes

  • New feature (non-breaking change which adds core functionality)
  • Documentation (update in the documentation)
  • Example inside the codes

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 22, 2023
@vmoens vmoens changed the title [Feat] TensorDictBase.masked_select_ inplace [Feature] TensorDictBase.masked_select_ inplace May 23, 2023
vmoens
vmoens reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for much for this!
Can you have a look at these few comments?

tensordict/tensordict.py Outdated Show resolved Hide resolved
tensordict/tensordict.py Outdated Show resolved Hide resolved
tensordict/tensordict.py Outdated Show resolved Hide resolved
@vmoens vmoens added the enhancement New feature or request label May 23, 2023
@vmoens
Copy link
Contributor

vmoens commented May 23, 2023

We should test that feature too!

@xmaples
Copy link
Contributor Author

xmaples commented May 24, 2023

Testing codes added

xmaples
xmaples commented Jun 1, 2023
View reviewed changes
Copy link
Contributor Author

@xmaples xmaples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmaples @vmoens @facebook-github-bot