[debug][dtensor] hosting commdebugmode browser's visualizer PyTorch #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for pytorch-dot-org-preview processing.
|
malfet
reviewed
Aug 2, 2024
| </div> | ||
| <div id="tree-container"></div> | ||
|
|
||
| <script src="https://cdn.jsdelivr.net/gh/pytorch/pytorch@main/torch/distributed/_tensor/debug/comm_mode_broswer_visual.js"></script> |
There was a problem hiding this comment.
What's wrong with referencing github script directly?
Suggested change
| <script src="https://cdn.jsdelivr.net/gh/pytorch/pytorch@main/torch/distributed/_tensor/debug/comm_mode_broswer_visual.js"></script> | |
| <script src="https://raw.githubusercontent.com/pytorch/pytorch/main/torch/distributed/_tensor/debug/comm_mode_broswer_visual.js"></script> |
|
Maybe we can start with a private html (with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of CommDebugMode's features is that it allows users to create a json file using the debugger's output and create a tree structure of the results in a browser visualizer. I would like to host this html file on pytorch so that users don't have to constantly open the html file manually every single time they want to use it.