Skip to content

Commit

Permalink
Fix CPU Trace Message (#1018)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #1018

Several users have complained about how the current CPU trace iteration message is confusing. They tend to think that this means there is only one step iteration recorded. Lets change the wording to make it clear it is an entire span that is being recorded. Lets also make it clear this is for specifically CPU

Reviewed By: aaronenyeshi

Differential Revision: D66683879

fbshipit-source-id: 648a5adc625474050a7e918324dae96d5c2b6767
  • Loading branch information
sraikund16 authored and facebook-github-bot committed Dec 3, 2024
1 parent 669fa5b commit 698c71c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions libkineto/src/CuptiActivityProfiler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1368,10 +1368,10 @@ const time_point<system_clock> CuptiActivityProfiler::performRunLoopStep(
void CuptiActivityProfiler::finalizeTrace(
const Config& config,
ActivityLogger& logger) {
LOG(INFO) << "Traces Recorded:";
LOG(INFO) << "CPU Traces Recorded:";
{
for (const auto& it : iterationCountMap_) {
LOG(INFO) << it.first << ": " << it.second << " iterations";
LOG(INFO) << it.first << ": " << it.second << " span(s) recorded";
}
iterationCountMap_.clear();
}
Expand Down

0 comments on commit 698c71c

Please sign in to comment.