Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multidataset round robin sampler #1370

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Multidataset round robin sampler #1370

wants to merge 10 commits into from

Conversation

ramanishsingh
Copy link
Contributor

@ramanishsingh ramanishsingh commented Nov 21, 2024 •
edited
Loading

This PR attempts to add a new sampler, Round robin sampler.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 21, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1370

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures

As of commit 7ea0cc9 with merge base 60380f1 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ramanishsingh ramanishsingh marked this pull request as ready for review December 3, 2024 17:01
divyanshk
divyanshk reviewed Dec 3, 2024
View reviewed changes
torchdata/nodes/samplers/multi_node_round_robin_sampler.py
from torchdata.nodes.samplers.stop_criteria import StopCriteria


class MultiNodeRoundRobinSampler(BaseNode[T]):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the expected behavior when doing many epochs over all the datasets? Would every epoch be the same?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, every epoch would be the same. Added a new test for that.

data/test/nodes/test_multi_node_round_robin_sampler.py

Line 177 in 5f63705

def test_multiple_epochs(self) -> None:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyanshk divyanshk Awaiting requested review from divyanshk

@andrewkho andrewkho Awaiting requested review from andrewkho

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramanishsingh @divyanshk @facebook-github-bot