-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix neuron conductance pyre fixme issues #1458
Open
vivekmig
wants to merge
4
commits into
pytorch:master
Choose a base branch
from
vivekmig:export-D67523217
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D67523217 |
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Dec 20, 2024
Summary: Pull Request resolved: pytorch#1458 Differential Revision: D67523217
vivekmig
force-pushed
the
export-D67523217
branch
from
December 20, 2024 20:57
8a4ea82
to
56961b0
Compare
This pull request was exported from Phabricator. Differential Revision: D67523217 |
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Dec 20, 2024
Summary: Pull Request resolved: pytorch#1458 Differential Revision: D67523217
vivekmig
force-pushed
the
export-D67523217
branch
from
December 20, 2024 23:06
56961b0
to
db2559b
Compare
This pull request was exported from Phabricator. Differential Revision: D67523217 |
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Dec 22, 2024
Summary: Pull Request resolved: pytorch#1458 Differential Revision: D67523217
vivekmig
force-pushed
the
export-D67523217
branch
from
December 22, 2024 13:54
db2559b
to
decb223
Compare
This pull request was exported from Phabricator. Differential Revision: D67523217 |
Summary: Python 3.8 has reached EOL in Oct 2024, so we can upgrade minimum python required for Captum to 3.9. We are seeing test failures due to dependencies when running with Python 3.8, so upgrading minimum version to resolve these. Differential Revision: D67545940
Summary: Currently, Captum OSS tests are failing due to mypy failures (likely from new version) in DeepLift test cases. Adds fix for type failure caused by different signature between DeepLift and DeepLiftShap. Differential Revision: D67538043
Summary: Pull Request resolved: pytorch#1457 Differential Revision: D67523072
Summary: Pull Request resolved: pytorch#1458 Differential Revision: D67523217
vivekmig
force-pushed
the
export-D67523217
branch
from
December 22, 2024 14:46
decb223
to
41f62d5
Compare
This pull request was exported from Phabricator. Differential Revision: D67523217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D67523217