Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fbcode/pytorch to Python Scientific Stack 2 (#3845) #1387

Closed
wants to merge 1 commit into from

Conversation

igorsugak
Copy link
Contributor

Summary: Pull Request resolved: pytorch/audio#3845

Differential Revision: D64008689

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64008689

igorsugak added a commit to igorsugak/opacus that referenced this pull request Oct 18, 2024
igorsugak added a commit to igorsugak/opacus that referenced this pull request Oct 18, 2024
igorsugak added a commit to igorsugak/captum that referenced this pull request Oct 18, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64008689

igorsugak added a commit to igorsugak/botorch that referenced this pull request Oct 18, 2024
igorsugak added a commit to igorsugak/audio that referenced this pull request Oct 18, 2024
igorsugak added a commit to igorsugak/audio that referenced this pull request Oct 18, 2024
…ch#3845)

Summary:
X-link: pytorch/opacus#680
X-link: pytorch/captum#1387
X-link: pytorch/botorch#2584

This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: 
```counterexample
Generic type `ndarray` expects 2 type parameters.
```
`numpy.typing.NDArray` is an alias that provides default template parameters.

Differential Revision: D64619891
igorsugak added a commit to igorsugak/botorch that referenced this pull request Oct 18, 2024
Summary:
X-link: pytorch/audio#3846

X-link: pytorch/opacus#680
X-link: pytorch/captum#1387
X-link: pytorch/audio#3845

This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: 
```counterexample
Generic type `ndarray` expects 2 type parameters.
```
`numpy.typing.NDArray` is an alias that provides default template parameters.

Differential Revision: D64619891
igorsugak added a commit to igorsugak/captum that referenced this pull request Oct 18, 2024
Summary:
X-link: pytorch/audio#3846

X-link: pytorch/opacus#680
X-link: pytorch/botorch#2584
X-link: pytorch/audio#3845

This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: 
```counterexample
Generic type `ndarray` expects 2 type parameters.
```
`numpy.typing.NDArray` is an alias that provides default template parameters.

Differential Revision: D64619891
igorsugak added a commit to igorsugak/opacus that referenced this pull request Oct 18, 2024
Summary:
X-link: pytorch/captum#1389

X-link: pytorch/botorch#2586

X-link: pytorch/audio#3846

X-link: pytorch/captum#1387
X-link: pytorch/botorch#2584
X-link: pytorch/audio#3845

This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: 
```counterexample
Generic type `ndarray` expects 2 type parameters.
```
`numpy.typing.NDArray` is an alias that provides default template parameters.

Differential Revision: D64619891
igorsugak added a commit to igorsugak/captum that referenced this pull request Oct 18, 2024
Summary: Pull Request resolved: pytorch#1387

Differential Revision: D64008689
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64008689

igorsugak added a commit to igorsugak/captum that referenced this pull request Oct 18, 2024
Summary: Pull Request resolved: pytorch#1387

Differential Revision: D64008689
igorsugak added a commit to igorsugak/captum that referenced this pull request Oct 18, 2024
Summary: Pull Request resolved: pytorch#1387

Differential Revision: D64008689
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64008689

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64008689

Summary: Pull Request resolved: pytorch#1387

Reviewed By: ipazarbasi

Differential Revision: D64008689
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64008689

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1ba8977.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants