-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade fbcode/pytorch to Python Scientific Stack 2 (#3845) #1387
Conversation
This pull request was exported from Phabricator. Differential Revision: D64008689 |
Summary: X-link: pytorch/captum#1387 X-link: pytorch/botorch#2584 X-link: pytorch/audio#3845 Differential Revision: D64008689
Summary: X-link: pytorch/captum#1387 X-link: pytorch/botorch#2584 X-link: pytorch/audio#3845 Differential Revision: D64008689
Summary: X-link: pytorch/opacus#680 X-link: pytorch/botorch#2584 X-link: pytorch/audio#3845 Differential Revision: D64008689
8ee3699
to
7006fe3
Compare
This pull request was exported from Phabricator. Differential Revision: D64008689 |
Summary: X-link: pytorch/opacus#680 X-link: pytorch/captum#1387 X-link: pytorch/audio#3845 Differential Revision: D64008689
…ytorch#3845) Summary: X-link: pytorch/opacus#680 X-link: pytorch/captum#1387 X-link: pytorch/botorch#2584 Differential Revision: D64008689
…ch#3845) Summary: X-link: pytorch/opacus#680 X-link: pytorch/captum#1387 X-link: pytorch/botorch#2584 This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: ```counterexample Generic type `ndarray` expects 2 type parameters. ``` `numpy.typing.NDArray` is an alias that provides default template parameters. Differential Revision: D64619891
Summary: X-link: pytorch/audio#3846 X-link: pytorch/opacus#680 X-link: pytorch/captum#1387 X-link: pytorch/audio#3845 This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: ```counterexample Generic type `ndarray` expects 2 type parameters. ``` `numpy.typing.NDArray` is an alias that provides default template parameters. Differential Revision: D64619891
Summary: X-link: pytorch/audio#3846 X-link: pytorch/opacus#680 X-link: pytorch/botorch#2584 X-link: pytorch/audio#3845 This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: ```counterexample Generic type `ndarray` expects 2 type parameters. ``` `numpy.typing.NDArray` is an alias that provides default template parameters. Differential Revision: D64619891
Summary: X-link: pytorch/captum#1389 X-link: pytorch/botorch#2586 X-link: pytorch/audio#3846 X-link: pytorch/captum#1387 X-link: pytorch/botorch#2584 X-link: pytorch/audio#3845 This replaces uses of `numpy.ndarray` in type annotations with `numpy.typing.NDArray`. In Numpy-1.24.0+ `numpy.ndarray` is annotated as generic type. Without template parameters it triggers static analysis errors: ```counterexample Generic type `ndarray` expects 2 type parameters. ``` `numpy.typing.NDArray` is an alias that provides default template parameters. Differential Revision: D64619891
Summary: Pull Request resolved: pytorch#1387 Differential Revision: D64008689
7006fe3
to
01ded86
Compare
This pull request was exported from Phabricator. Differential Revision: D64008689 |
01ded86
to
5db0ee8
Compare
Summary: Pull Request resolved: pytorch#1387 Differential Revision: D64008689
5db0ee8
to
4338362
Compare
Summary: Pull Request resolved: pytorch#1387 Differential Revision: D64008689
This pull request was exported from Phabricator. Differential Revision: D64008689 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D64008689 |
Summary: Pull Request resolved: pytorch#1387 Reviewed By: ipazarbasi Differential Revision: D64008689
4338362
to
3b64a95
Compare
This pull request was exported from Phabricator. Differential Revision: D64008689 |
This pull request has been merged in 1ba8977. |
Summary: Pull Request resolved: pytorch/audio#3845
Differential Revision: D64008689