-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FOBO Tutorial #2137
base: main
Are you sure you want to change the base?
Add FOBO Tutorial #2137
Conversation
The job is defined here: https://github.com/pytorch/botorch/blob/main/.github/workflows/tutorials_smoke_test_on_pr.yml#L10-L17, so you'll see that this will run against the latest changes on the main / primary branch of pytorch/gpytorch/botorch: https://github.com/pytorch/botorch/blob/main/.github/workflows/reusable_tutorials.yml#L53-L55 Can you see the logs here: https://github.com/pytorch/botorch/actions/runs/7079121747/job/19265397371?pr=2137 ? The setup stages show the logs including which packages are installed (assuming there isn't any permissions issue with viewing the full logs). |
That doesn't appear to be the case for me, it looks like it's a result of this PR from GPyTorch (cornellius-gp/gpytorch#2288) which changes the shapes of some objects (in particular, mean_cache, which used to be size [5,1,1,44] to [5,5,5,44]). My code runs on the commit just before that one, using the latest BoTorch commit, but breaks when using the commit from the PR (cornellius-gp/gpytorch#2288). |
This change in particular is where I think the issue is: |
Ok, so I got it working locally, I changed
to
and it works as before. This extracts the relevant dimensions to match what was previously working. I verified heuristically that the dimensions I got rid of were copies of one another, so we keep the relevant data. I'm not sure why caused the shape of mean_cache went from [5,1,1,4] to [5,5,5,4], in the first place (maybe from #2011, like you mentioned ?), but I just put in a PR in GPyTorch for this change for now. Hopefully those tests pass... lol EDIT: Unit tests aren't passing but neither are the ones in main for GPyTorch, so I'll assume this change is what's needed for now. (link: cornellius-gp/gpytorch#2452) |
Any updates on how to get this through? I had someone reach out to me today because they ran into the same issue (yyexela@a39e6f5#commitcomment-137448122). I believe all we need is for (cornellius-gp/gpytorch#2452) to merge. Thanks! |
Hi @yyexela . Thanks for the tutorial! I requested a review on the GPyTorch PR, hopefully someone will get to it soon. We're trying out a new support model for community contributions: https://github.com/pytorch/botorch/blob/main/CONTRIBUTING.md#community-contributions-beta. Once the GPyTorch fix lands, can you move the tutorial to the notebooks_community directory and add the contributor info and other metadata as outlined in the readme file? Thanks! |
Motivation
Add tutorial utilizing dKG and dNEI for dGP functionality.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
N/A (notebook runs without issues).
Related PRs
#1679