NoisyExpectedImprovementMixin
#1939
Open
+904
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: pytorch#1937 This commit introduces `qLogNoisyExpectedImprovement` (`qLogNEI`) a cousin of `qLogEI`. Similar to `qLogEI` and in contrast to `q(N)EI`, it generally exhibits strong and smooth gradients, leading to better acquisition function optimization and Bayesian optimization as a result. Differential Revision: https://internalfb.com/D47439161 fbshipit-source-id: 8a50f123e2f4a828934c8bc4fba0a163e0c0abb4
Summary: This commit introduces a mixin design to increase code sharing between `qLogNEI` and `qNEI`. Differential Revision: D47511290 fbshipit-source-id: efe6b1550948c5df7da1e185c7770ba062d60b06
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47511290 |
Codecov Report
@@ Coverage Diff @@
## main #1939 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 177 177
Lines 15596 15613 +17
=======================================
+ Hits 15588 15605 +17
Misses 8 8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This commit introduces a mixin design to increase code sharing between
qLogNEIandqNEI.Differential Revision: D47511290