[llama] Remove unnecessary model attribute assignment on 'freqs_cis' #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BowenBao
changed the title
msaroufim
approved these changes
Jul 13, 2023
|
CI failure seems to be a flake not your fault, id retry triggering build |
|
The upstream model code has a similar issue: https://github.com/facebookresearch/llama/blob/main/llama/model.py#L226 The convention is before we merge this PR, we require the PR author to create a PR to fix the upstream model code as well, and reference the upstream PR link in the code of torchbench model. |
xuzhao9
reviewed
Jul 14, 2023
| @@ -224,8 +224,8 @@ def forward(self, tokens: torch.Tensor, start_pos: int): | |||
|
|
|||
| h = self.tok_embeddings(tokens) | |||
|
|
|||
| self.freqs_cis = self.freqs_cis.to(h.device) | |||
| freqs_cis = self.freqs_cis[start_pos : start_pos + seqlen] | |||
| freqs_cis = self.freqs_cis.to(h.device) | |||
There was a problem hiding this comment.
Can we add a reference to meta-llama/llama#349 here?
BowenBao
commented
Jul 14, 2023
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1767, more details there.
Upstream PR link meta-llama/llama#349