Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export chrome trace when profiler is enabled #1760

Closed
wants to merge 1 commit into from

Conversation

dshi7
Copy link
Contributor

@dshi7 dshi7 commented Jul 10, 2023

Summary: as title. default off (enabled by --profile-trace)

Reviewed By: xuzhao9

Differential Revision: D47234285

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47234285

Copy link
Member

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wondering if the option should be a little more descriptive, like profile-export-chrome-trace or -profile-export-chrome

dshi7 added a commit to dshi7/benchmark that referenced this pull request Jul 10, 2023
Summary:
Pull Request resolved: pytorch#1760

as title.  default off (enabled by `--profile-export-chrome-trace`)

Reviewed By: aaronenyeshi, xuzhao9

Differential Revision: D47234285

fbshipit-source-id: 0481dfa6d161e1df36cfa85cd63f9a73b59ddd85
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47234285

Summary:
Pull Request resolved: pytorch#1760

as title.  default off (enabled by `--profile-export-chrome-trace`)

Reviewed By: aaronenyeshi, xuzhao9

Differential Revision: D47234285

fbshipit-source-id: 18e5fa33cd36e6f0eb2005624177364dd51db0d6
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47234285

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in bfb6d15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants