Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CUDA 12.5 build #3811

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix CUDA 12.5 build #3811

wants to merge 1 commit into from

Conversation

HennerM
Copy link

@HennerM HennerM commented Jul 15, 2024

CUDA 12.5 removed the FLT_MAX symbol.
This was previously used without being explicitly imported. FLT_MAX is defined in <float.h>, including this header fixes the issue.

PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.

A similar issue has been reported in Kaldi before: kaldi-asr/kaldi#4914

CUDA 12.5 removed the FLT_MAX symbol.
This was previously used without being explicitly imported.
FLT_MAX is defined in <float.h>, including this header fixes the issue
@HennerM HennerM requested a review from a team as a code owner July 15, 2024 13:07
Copy link

pytorch-bot bot commented Jul 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3811

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @HennerM!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@HennerM
Copy link
Author

HennerM commented Aug 19, 2024

@atalman do you mind having a look at this? I can't build Torchaudio on CUDA 12.5 without this fix in, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants