Enabled python runtime saving #2999
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: api [Python]
narendasan
reviewed
Jul 15, 2024
| state.pop("input_shapes", None) | ||
| state.pop("output_dtypes", None) | ||
| state.pop("output_shapes", None) | ||
| state.pop("active_stream", None) |
There was a problem hiding this comment.
I dont think this data should be serialized. It should be reconstructed on reload
There was a problem hiding this comment.
These data are poped from the dict so they are not serialized
narendasan
reviewed
Jul 15, 2024
| state.pop("output_dtypes", None) | ||
| state.pop("output_shapes", None) | ||
| state.pop("active_stream", None) | ||
| state.pop("target_device_properties", None) |
There was a problem hiding this comment.
Do we reuse this data on load to set up the engine properly?
There was a problem hiding this comment.
Yes. Line 163 initialized all these data
narendasan
reviewed
Jul 30, 2024
| self.__dict__.update(state) | ||
| self.target_device_properties = torch.cuda.get_device_properties( |
There was a problem hiding this comment.
The deserialization should make sure that the gpu matches the gpu the engine was built on instead of just changing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: