sorted() does not enforce comparable items in an iterable of tuples is fixed #13297 #13303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: scipy (https://github.com/scipy/scipy)
- scipy/spatial/tests/test_spherical_voronoi.py:194: error: Value of type variable "SupportsRichComparisonT" of "sorted" cannot be "floating[Any]" [type-var]
+ scipy/spatial/tests/test_spherical_voronoi.py:194: error: Need type annotation for "closest" [var-annotated]
jax (https://github.com/google/jax)
+ jax/_src/interpreters/mlir.py:1168: error: Argument 1 to "tuple" has incompatible type "list[tuple[Never, ...]]"; expected "Iterable[str]" [arg-type]
spack (https://github.com/spack/spack)
+ lib/spack/spack/binary_distribution.py:906: error: Need type annotation for "index" [var-annotated]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve added an overload for the sorted() function that explicitly handles tuples with elements that support SupportsRichComparison. This ensures that the tuples only contain comparable elements, and the type checker will catch any issues before runtime.
Explain :
Added a Specialized Overload for Tuples:
The third overload explicitly specifies that when sorting tuples, all elements in the tuple must satisfy SupportsRichComparison.
This ensures that sorted only works for tuples where every element is fully comparable.If a key function is provided, the burden of ensuring comparability is transferred to the result of the key function.