fix deprecated ast classes #13285
Open
fix deprecated ast classes #13285
+24
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
| @@ -1186,12 +1186,18 @@ class Slice(_Slice): | |||
| ) -> Self: ... | |||
|
|
|||
| class ExtSlice(slice): # deprecated and moved to ast.py if sys.version_info >= (3, 9) | |||
There was a problem hiding this comment.
While you're here could you also @deprecated these two?
There was a problem hiding this comment.
I went ahead and added it for all the classes deprecated in 3.9. I didn't bother making a 3.8 branch without @deprecated since that's just one version and EOL anyway. The descriptions are all taken from the docstrings in ast.py.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment on these was incorrect, but there were a lot of other AST classes where that was the case. Here, they switched from an
__init__to a__new__when they were deprecated, in order to return an instance of their replacement.