Support @deprecated()
on overloaded __get__
for generic descriptors
#18333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18323.
Follow up on #18090.
Notes:
analyze_descriptor_access
, there is a distinction betweentyp
anddescriptor_type
:mypy/mypy/checkmember.py
Lines 687 to 688 in 9ff9946
map_instance_to_supertype
returnsdescriptor_type
unchanged. The reason I'm mentioning this is thatexpand_type_by_instance
usestyp
and notdescriptor_type
. Inwarn_deprecated_overload_item
, we have access todescriptor_type
(passed asselftype
):mypy/mypy/checkmember.py
Lines 726 to 728 in 9ff9946
expand_type_by_instance(candidate, selftype)
. Is this going to be an issue?selftype
toInstance
. Is this going to be an issue?