Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypyc] Fixing InitVar for dataclasses. #18319

Merged
merged 1 commit into from
Dec 27, 2024
Merged

[mypyc] Fixing InitVar for dataclasses. #18319

merged 1 commit into from
Dec 27, 2024
+20 −1

Conversation

advait-dixit
Copy link
Contributor

Fixes mypyc/mypyc#934.

InitVar variables are not attributes of a dataclass PyTypeObject. Adding check before removing InitVar keys from PyTypeObject in CPyDataclass_SleightOfHand.

hauntsaninja
hauntsaninja approved these changes Dec 27, 2024
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, thanks!

@hauntsaninja hauntsaninja merged commit 6d13d0d into python:master Dec 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mypyc generates AttributeError: exception on basic use of InitVar
2 participants
@advait-dixit @hauntsaninja