Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-128265: support wasi/emscripten on pdb tests, by removing asyncio from pdb tests #128264

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-128265: support wasi/emscripten on pdb tests, by removing asyncio from pdb tests #128264

wants to merge 1 commit into from
+61 −53

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Dec 25, 2024 •
edited by bedevere-app bot
Loading

@graingert graingert changed the title support wasi/emscripten on pdb tests support wasi/emscripten on pdb tests, by removing asyncio from pdb tests Dec 25, 2024
@graingert graingert changed the title support wasi/emscripten on pdb tests, by removing asyncio from pdb tests gh-128265: support wasi/emscripten on pdb tests, by removing asyncio from pdb tests Dec 25, 2024
@bedevere-app bedevere-app bot mentioned this pull request Dec 25, 2024
Open
@graingert graingert marked this pull request as ready for review December 25, 2024 22:01
@graingert graingert requested a review from Eclips4 December 26, 2024 09:30
graingert
graingert commented Dec 26, 2024
View reviewed changes
Lib/test/test_pdb.py
@@ -20,8 +20,7 @@
from test.support.pty_helper import run_pty, FakeInput
from unittest.mock import patch

# gh-114275: WASI fails to run asyncio tests, similar skip than test_asyncio.
SKIP_ASYNCIO_TESTS = (not support.has_socket_support)
SKIP_CORO_TESTS = False
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left this in otherwise the diff is a bit noisy without whitespace hidden.

happy to remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaogaotiantian gaogaotiantian Awaiting requested review from gaogaotiantian gaogaotiantian is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@Eclips4 Eclips4 Awaiting requested review from Eclips4

Assignees
No one assigned
Labels
awaiting review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@graingert