Homepage project urls #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amjith
force-pushed
the
homepage-project-urls
branch
from
8800b8c to
d395a83
Compare
thatch
reviewed
Nov 13, 2024
| n = v.setup_call_args.get("name") | ||
| if n: | ||
| if n is UNKNOWN: | ||
| raise ValueError("Complex setup call can't extract name") |
There was a problem hiding this comment.
I think long-term these shouldn't raise; the snippets above do that because finding deps was the original use of this. It doesn't matter for your artifact-validation use case though.
thatch
reviewed
Nov 13, 2024
README.md
Outdated
| provides_extra=frozenset(), | ||
| name='pynt', | ||
| requires_python='>=3.6', | ||
| url='https://stash.corp.netflix.com/projects/NFPY/repos/pynt/browse', |
There was a problem hiding this comment.
Are you happy with this example? Maybe use requests or something more recognizable instead?
thatch
reviewed
Nov 13, 2024
README.md
Outdated
| ) | ||
| ``` | ||
|
|
||
| The metadata can be extracted from a `wheel`, `sdist` (zip or tarball). Check [`__init__.py`](metadata_please/__init__.py) file for all available functions. |
There was a problem hiding this comment.
also "most straightforward source checkouts"
thatch
reviewed
Nov 13, 2024
metadata_please/source_checkout.py
Outdated
| @@ -229,6 +367,8 @@ def from_setup_cfg_checkout(path: Path) -> bytes: | |||
| "Requires-Dist: " + merge_extra_marker(extra_name, i) + "\n" | |||
| ) | |||
|
|
|||
| # TODO name requires_python url project_urls | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That was tedious but it is now done.