Add basic setup.py extraction #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatch
commented
Sep 20, 2024
| return True | ||
|
|
||
|
|
||
| class QualifiedNameSaver(ShortCircuitingVisitor): |
There was a problem hiding this comment.
Note: currently doesn't use the short-circuiting feature for anything but skipping func(setup(...)) by accident.
thatch
commented
Sep 20, 2024
| Path(d, "setup.py").write_text( | ||
| "from setuptools import setup; setup(install_requires=blarg)" | ||
| ) | ||
| with self.assertRaises(ValueError): |
There was a problem hiding this comment.
Ought to match on message too
amjith
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not that impressive, but a starting point that works for simple enough cases with only stdlib.
setup.py(if it exists) be parseable in the current python, and raises otherwiseimport setuptoolsandfrom setuptools import setupare all I've really checked)I would estimate this only works for ~40% of the real-world
setup.py, while the dowsing impl works for more like ~70%. I'm intending to use this forhdeps .support right now, but the same basic code would be useful in a future advice that migrates to pep621 metadata (right now we don't save any positions, so editing the args is not possible). See past use in opine for how this might be used.