Fix invalid PrometheusRule when adding grouping to a ratio indicator

pyrra-dev · Feb 4, 2024 · 6bf8659 · 6bf8659
1 parent 83b0b8b
commit 6bf8659
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/kubernetes/controllers/servicelevelobjective.go b/kubernetes/controllers/servicelevelobjective.go
@@ -180,9 +180,9 @@ func makeConfigMap(name string, kubeObjective pyrrav1alpha1.ServiceLevelObjectiv
 				return nil, fmt.Errorf("failed to get generic rules: %w", err)
 			}
 			// ignore these rules
+		} else {
+			rule.Groups = append(rule.Groups, rules)
 		}
-
-		rule.Groups = append(rule.Groups, rules)
 	}
 
 	bytes, err := yaml.Marshal(rule)
@@ -244,9 +244,9 @@ func makePrometheusRule(kubeObjective pyrrav1alpha1.ServiceLevelObjective, gener
 				return nil, fmt.Errorf("failed to get generic rules: %w", err)
 			}
 			// ignore these rules
+		} else {
+			rule.Groups = append(rule.Groups, rules)
 		}
-
-		rule.Groups = append(rule.Groups, rules)
 	}
 
 	isController := true