Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply repo-review suggestions #1519

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Apply repo-review suggestions #1519

wants to merge 2 commits into from

Commits on Sep 10, 2024

  1. Apply repo-review suggestion RF003 

    RF003: src directory doesn't need to be specified anymore (0.6+)

Ruff now (0.6+) looks in the src directory by default. The src
setting doesn't need to be specified if it's just set to `["src"]`.
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    c6c51e5 View commit details
    Browse the repository at this point in the history

  2. Apply repo-review MyPy suggestions 

    MY103: MyPy warn unreachable

Must have `warn_unreachable` (true/false) to pass this check. There are
occasionally false positives (often due to platform or Python version
static checks), so it's okay to set it to false if you need to. But try
it first - it can catch real bugs too.

MY104: MyPy enables ignore-without-code

Must have `"ignore-without-code"` in `enable_error_code = [...]`. This
will force all skips in your project to include the error code, which
makes them more readable, and avoids skipping something unintended.

MY105: MyPy enables redundant-expr

Must have `"redundant-expr"` in `enable_error_code = [...]`. This helps
catch useless lines of code, like checking the same condition twice.

MY106: MyPy enables truthy-bool

Must have `"truthy-bool"` in `enable_error_code = []`. This catches
mistakes in using a value as truthy if it cannot be falsy.
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    40c7227 View commit details
    Browse the repository at this point in the history