Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Windows CI across all supported Python versions #13016

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ichard26
Copy link
Member

Let's see how slow or not slow this is...

This still needs updates to the development documentation.

@ichard26
Copy link
Member Author

ichard26 commented Oct 20, 2024

They're on par with the rest of the CI jobs. This should be okay to deploy. PTAL.

@sbidoul
Copy link
Member

sbidoul commented Oct 20, 2024

My only reservation would be that the probability of failure in those jobs (that would not also be revealed by the linux jobs) is so low that it may not be worth the additional heating of the planet.

@notatallshaw
Copy link
Member

My only reservation would be that the probability of failure in those jobs (that would not also be revealed by the linux jobs) is so low that it may not be worth the additional heating of the planet.

Following this logic, shouldn't everything that isn't latest/oldest be turned off other than macos-latest? Which seems to be the fastest of all the CI jobs.

Then all the other Python versions can be run on a schedule, like in #13014.

My only strong opinion here is that all versions of Python for all supported OSes should be tested before a release. OS-Python version specific issues do come up with pip.

@notatallshaw notatallshaw added this to the 25.0 milestone Nov 10, 2024
@notatallshaw
Copy link
Member

I'm going to (cheekly) put this on to the 25.0 milestone, so this approach can be accepted or rejected by then, discussion was here: #13011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants