Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Expand testing for wheel multi-version multi-platform #608

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jacobdr
Copy link

@jacobdr jacobdr commented Nov 7, 2022

Following this past week's issue with wheel==0.38, this adds slightly more testing to help guard against a similar issue in this package. While its somewhat duplicative of what might already be tested in test_tags.py, since this is the most natural place to put an "end-user" consumption test (viz the internals), I thought the juice was worth the squeeze as a defensive test.

I submitted a PR with similar testing to the wheel package via pypa/wheel#486, but since the intention is to have wheel depend on packaging eventually, I also wanted to make a similar contribution here.

  • Add slightly more testing to the wheel and sdist tests
  • Add venv to the .gitignore

.gitignore Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
@brettcannon
Copy link
Member

@jacobdr please refresh my review when you're ready for me to have another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants