Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy multi-platform images #1412

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

messense
Copy link
Contributor

@messense messense commented Nov 7, 2022

@@ -0,0 +1 @@
#!/bin/bash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: write the script to actually create the multi-platform docker manifest.

Comment on lines +83 to +91
- name: Wait for Travis CI
uses: fountainhead/[email protected]
id: wait-for-travis
with:
token: ${{ secrets.GITHUB_TOKEN }}
checkName: Travis CI - Pull Request
ref: ${{ github.event.pull_request.head.sha || github.sha }}
intervalSeconds: 10
timeoutSeconds: 3600
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I expect the Travis CI check to fail every now and then (appart from the timeout being way too short for a Travis CI build).

This should really be a different workflow, possibly triggered by the checks being updated on main ?

Copy link
Contributor Author

@messense messense Nov 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A different workflow should be fine, but it's harder to test since it can only run after merging, see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run

You could extract it to a separate workflow afterwards.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to leave this here at the moment as you're saying.
It shouldn't be to hard to split with the deployment script being a separate bash script.

Comment on lines +93 to +99
- name: Deploy
if: steps.wait-for-travis.outputs.conclusion == 'success'
run: ./deploy_multi_platform.sh

- name: Error on failure
if: steps.wait-for-travis.outputs.conclusion != 'success'
run: exit 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe if this was a single step, the workflow could be re-run with failing steps only. This would require a manual action though hence I still prefer to have a separate workflow triggered on check updates if possible (only need to worry about Travis CI mostly in that case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants