Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CFLAGS if set as-is, match CXXFLAGS behavior #322

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use CFLAGS if set as-is, match CXXFLAGS behavior #322

wants to merge 1 commit into from

Conversation

thesamesam
Copy link

Since 2c93711, CXXFLAGS is used as-is if set in the envionment rather than clobbered by whatever CPython happened to be built with.

Do the same for CFLAGS: use it as-is if set in the environment, don't prepend CPython's saved flags.

Fixes: #299

@thesamesam
Use CFLAGS if set as-is, match CXXFLAGS behavior
b6e88a0 
Since 2c93711, CXXFLAGS is used
as-is if set in the envionment rather than clobbered by whatever
CPython happened to be built with.

Do the same for CFLAGS: use it as-is if set in the environment, don't
prepend CPython's saved flags.

Fixes: pypa#299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CXXFLAGS overrides default flags, CFLAGS doesn't
1 participant
@thesamesam