chore: drop deprecated options related to CIBW_ENABLE
#2095
Conversation
| parser.add_argument( | ||
| "--prerelease-pythons", | ||
| action="store_true", | ||
| help="Enable pre-release Python versions if available.", | ||
| ) | ||
|
|
There was a problem hiding this comment.
Should we be keeping the command line option but turn it in an enable in options.py ?
There was a problem hiding this comment.
Should we instead support --enable=<opt> --enable=<opt>? We also now have --only, which you can use to build a pre-release wheel, so maybe we don't need a CLI option for this anymore? (It also is supported statically now)
There was a problem hiding this comment.
Only a few projects are using this in their CI and those could probably move to the static definition (despite our recommendation not to deliver wheels in pre-ABI stability, for now at least).
I liked --prerelease-pythons better than --only because it allows to check musl/glibc, gil/no-gil and multiple architectures in just one pass.
For UNIX users debugging locally, CIBW_ENABLE=cpython-prerelease cibuildwheel ... works quite easily so probably not worth adding an --enable flag. It might be a bit more painful on Windows if you don't want to leave the environment variable after execution (don't know if there's a one liner there) but we can still probably live without a new option as well.
So, maybe just remove the option for now ?
henryiii
added
the
Hold for future release
mayeut
force-pushed
the
enable-legacy-removal
branch
from
b24ba79 to
4097d72
Compare
mayeut
force-pushed
the
enable-legacy-removal
branch
from
4097d72 to
6d9ce82
Compare
Drop deprecated options related to
CIBW_ENABLE.based on #1912