Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't create empty .libs directory #489

Merged
merged 4 commits into from
Jun 2, 2024
Merged

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Jun 1, 2024

close #488

only create ${package}.libs when needed

@trim21 trim21 marked this pull request as ready for review June 1, 2024 00:39
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.94%. Comparing base (e969b7b) to head (760b3f3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
+ Coverage   91.87%   91.94%   +0.07%     
==========================================
  Files          20       20              
  Lines        1267     1266       -1     
  Branches      279      279              
==========================================
  Hits         1164     1164              
  Misses         57       57              
+ Partials       46       45       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mayeut
Copy link
Member

mayeut commented Jun 1, 2024

Thanks for your contribution, would you be able to add a test case for this as well (in tests/integration/test_manylinux.py:AnyLinux, the testsimple project can be used for the new test as it has no external dependency) ?

@mayeut mayeut merged commit d6e5b69 into pypa:main Jun 2, 2024
11 checks passed
@trim21 trim21 deleted the empty-lib-dir branch June 2, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repair add empty ${package}.lib directory to wheel
3 participants