Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8+ rollup #13

Closed
wants to merge 3 commits into from
Closed

Conversation

absalomedia
Copy link

Modify Rework Pure for IE8+ only & include pure-u-0 rollup from previous outstanding PR

Modify Rework Pure for IE8+ only & include pure-u-0 rollup from previous outstanding PR
@denizdogan
Copy link
Contributor

I guess the pull request I just made conflicts with yours: #15

Did I miss something when adding the .pure-u-XY-0 solution? Because your solution seems more complex?

@absalomedia
Copy link
Author

absalomedia commented Aug 31, 2016

The rollup I've done includes #10 as it was outstanding & I needed to get a working state solution for code already out in the wild.

#10 has LOC change of 12. #15 has LOC change of 13. How is #10 more complex?

@denizdogan
Copy link
Contributor

@absalomedia GitHub showed me this diff which was hard to decipher... I'll cancel my PR

@redonkulus
Copy link

@absalomedia I think the confusion in the diff is that its harder to understand what changed, it looks like the whole file was replaced, so its hard to review line by line. For example, just going to the "Files Changed" tab doesn't show the diff, I have to expand it and then it looks like a new file.

@ericf
Copy link
Collaborator

ericf commented Dec 2, 2016

@absalomedia @redonkulus I'm seeing the same thing.

@absalomedia
Copy link
Author

Should I close this & start the commits again? The whole file being changed may be related to encoding/spacing across different platforms I use to commit

@redonkulus
Copy link

@absalomedia I think that would help with the code review. Thanks!

@lkraav
Copy link
Collaborator

lkraav commented Dec 3, 2016

Should I close this & start the commits again? The whole file being changed may be related to encoding/spacing across different platforms I use to commit

@redonkulus time to commit .editorconfig?

$ [git:master] cat .editorconfig 
root = true

[*]
indent_style = space
indent_size = 4
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

@redonkulus redonkulus closed this Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants