-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE8+ rollup #13
IE8+ rollup #13
Conversation
Modify Rework Pure for IE8+ only & include pure-u-0 rollup from previous outstanding PR
I guess the pull request I just made conflicts with yours: #15 Did I miss something when adding the .pure-u-XY-0 solution? Because your solution seems more complex? |
@absalomedia GitHub showed me this diff which was hard to decipher... I'll cancel my PR |
@absalomedia I think the confusion in the diff is that its harder to understand what changed, it looks like the whole file was replaced, so its hard to review line by line. For example, just going to the "Files Changed" tab doesn't show the diff, I have to expand it and then it looks like a new file. |
@absalomedia @redonkulus I'm seeing the same thing. |
Should I close this & start the commits again? The whole file being changed may be related to encoding/spacing across different platforms I use to commit |
@absalomedia I think that would help with the code review. Thanks! |
@redonkulus time to commit
|
Modify Rework Pure for IE8+ only & include pure-u-0 rollup from previous outstanding PR