Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Helper CSS #338

Closed
wants to merge 4 commits into from
Closed

Added Helper CSS #338

wants to merge 4 commits into from

Conversation

phoenixh
Copy link

Added Helper CSS with Display and Hide Pure-U Blocks with Viewport.
Added Text Alignment class

Added Helper CSS with Display and Hide Pure-U Blocks with Viewport.
Added Text Alignment class
added offset to the cols
@phoenixh
Copy link
Author

added the offset of cols

Added center block class
added pull and push classes for blocks
@superscott
Copy link

+1 for formalized offset class.

@ericf
Copy link
Collaborator

ericf commented Jun 12, 2014

@phoenixh this adds a few things in one PR which I think are separate discussions — in fact there's already threads on most of these things: #326, #318

In general we want to avoid adding things to Pure that people can easily do in their app's CSS; e.g., .text-left is not something we'll ever add to Pure, because it can be easily done in the app's code base.

.display-md,
.display-lg,
.display-xl {
display: none !important;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the point of these, and using the word "display" to mean the absence of displaying is confusing.

@phoenixh
Copy link
Author

phoenixh commented Jul 2, 2014

@ericf as it is a helper class and some usefull classes are in that file i think it may be a good additional css file to use in the pure FW.

@ericf
Copy link
Collaborator

ericf commented Jul 10, 2014

@phoenixh Thanks again for creating these helpers. As I noted above, This is not something we want to add to Pure's core. But you should feel free to publish this as an extension that people can use with Pure.

@bchenSyd
Copy link

bchenSyd commented Mar 31, 2017

'I don't understand the point of these, and using the word "display" to mean the absence of displaying is confusing.'
it's meant to be overridden later. e.g.

@media (max-width: 767px) {
     .display-sm {
      display: block !important;
  }
}

so if you have a <div class='display-sm' >, that <div> is only visible in small screen.

I think this is the same as in bootstrap, almost a standard way to do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants