-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Helper CSS #338
Added Helper CSS #338
Conversation
Added Helper CSS with Display and Hide Pure-U Blocks with Viewport. Added Text Alignment class
added the offset of cols |
Added center block class
added pull and push classes for blocks
+1 for formalized offset class. |
@phoenixh this adds a few things in one PR which I think are separate discussions — in fact there's already threads on most of these things: #326, #318 In general we want to avoid adding things to Pure that people can easily do in their app's CSS; e.g., |
.display-md, | ||
.display-lg, | ||
.display-xl { | ||
display: none !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the point of these, and using the word "display" to mean the absence of displaying is confusing.
@ericf as it is a helper class and some usefull classes are in that file i think it may be a good additional css file to use in the pure FW. |
@phoenixh Thanks again for creating these helpers. As I noted above, This is not something we want to add to Pure's core. But you should feel free to publish this as an extension that people can use with Pure. |
'I don't understand the point of these, and using the word "display" to mean the absence of displaying is confusing.'
so if you have a I think this is the same as in |
Added Helper CSS with Display and Hide Pure-U Blocks with Viewport.
Added Text Alignment class